fix: emit warnings for silent parameter introspection failures#131
Open
fix: emit warnings for silent parameter introspection failures#131
Conversation
- Warn when *args or **kwargs are skipped during JSON Schema generation - Warn when parameter model generation fails in Tool.from_function() instead of silently producing an empty schema
Oaklight
force-pushed
the
fix/126-param-warnings
branch
from
77272cc to
56c2f8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UserWarningwhen*argsor**kwargsparameters are skipped during JSON Schema generationUserWarningwhen parameter model generation fails inTool.from_function(), instead of silently producing an empty schemaCloses #126
Test plan
*argsemits warning about JSON Schema exclusion**kwargsemits warning about JSON Schema exclusion*argsand**kwargsemits two warnings